fix: BrowserWindow.fromWebContents() can return null

[miniak]

Description of Change

Make it consistent with BrowserView.fromWebContents():

electron/lib/browser/api/browser-view.js

Lines 8 to 14 in 26d9ef9

	BrowserView.fromWebContents = (webContents) => {
	for (const view of BrowserView.getAllViews()) {
	if (view.webContents.equal(webContents)) return view
	}
	return null
	}

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed BrowserWindow.fromWebContents() to return null when no window is found for consistency with other APIs.

meant to comment

[codebytere]

I think we need to update some specs here?

[codebytere]

@miniak:

Unhandled exception in main spec runner: electron/spec-main/api-browser-window-spec.ts(1307,14): error TS2531: Object is possibly 'null'.

[alexeykuzmin]

👍 much better now

[alexeykuzmin]

@miniak can you please rebase onto the latest master?

[miniak]

@alexeykuzmin done

[release-clerk]

Release Notes Persisted

Fixed BrowserWindow.fromWebContents() to return null when no window is found for consistency with other APIs.