fix: gtk_init() was called twice in AtomBrowserMainParts

[ckerr]

Description of Change

Fixes #19984.

This one's super simple: don't call gtk_init() twice.

CC @codebytere

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed Linux console warning about gtk_disable_setlocale().

[codebytere]

Do we know why this was introduced to begin with?

[ckerr]

Funny thing, we're calling gtk_init() twice in 6-0-x too. 🤦‍♂️

What's changed is that Chromium added a call to gtk_disable_setlocale() in libgtkui::GtkInitFromCommandLine which triggered the warning s.t. now we're noticing it.

https://chromium.googlesource.com/chromium/src/+/218cc85df6ba817c2f33e91108345974e3293d63

[ckerr]

A little more context on this, for posterity's sake

First call

#0  0x00007fffcf00cb20 in gtk_init () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#1  0x00007fffd2a6ab92 in (anonymous namespace)::CommonInitFromCommandLine(base::CommandLine const&) (command_line=...)
    at ./../../chrome/browser/ui/libgtkui/gtk_util.cc:67
#2  0x00007fffd2a65c25 in libgtkui::GtkInitFromCommandLine(base::CommandLine const&) (command_line=...)
    at ./../../chrome/browser/ui/libgtkui/gtk_util.cc:85
#3  0x00007fffd2a65b2e in libgtkui::GtkUi::GtkUi() (this=0xe7a80985d60) at ./../../chrome/browser/ui/libgtkui/gtk_ui.cc:345
#4  0x00007fffd2a6a96e in BuildGtkUi() () at ./../../chrome/browser/ui/libgtkui/gtk_ui.cc:1075
#5  0x0000555556b030e1 in electron::AtomBrowserMainParts::PreEarlyInitialization() (this=0xe7a80944aa0)
    at ../../electron/shell/browser/atom_browser_main_parts.cc:269

Second call

#0  0x00007fffcf00cb20 in gtk_init () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
#1  0x00007fffd2a6ab92 in (anonymous namespace)::CommonInitFromCommandLine(base::CommandLine const&) (command_line=...)
    at ./../../chrome/browser/ui/libgtkui/gtk_util.cc:67
#2  0x00007fffd2a65c25 in libgtkui::GtkInitFromCommandLine(base::CommandLine const&) (command_line=...)
    at ./../../chrome/browser/ui/libgtkui/gtk_util.cc:85
#3  0x0000555556b03820 in electron::AtomBrowserMainParts::PreMainMessageLoopRun() (this=0xe7a80944aa0)
    at ../../electron/shell/browser/atom_browser_main_parts.cc:464

[release-clerk]

Release Notes Persisted

Fixed Linux console warning about gtk_disable_setlocale().

[trop]

I have automatically backported this PR to "7-0-x", please check out #20012