chore: add missing includes #20003
Merged
chore: add missing includes #20003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
force-pushed
the
alkuzmin/add-missing-include
branch
from
04e1f82
to
167818a
Compare
alexeykuzmin
commented
Aug 28, 2019
| #include "base/supports_user_data.h" | ||
| #include "base/values.h" |
There was a problem hiding this comment.
For base::DictionaryValue.
alexeykuzmin
commented
Aug 28, 2019
| @@ -14,7 +14,9 @@ | |||
|
|
|||
| #include "base/memory/weak_ptr.h" | |||
| #include "base/observer_list.h" | |||
| #include "base/strings/string16.h" | |||
There was a problem hiding this comment.
For base::string16.
alexeykuzmin
commented
Aug 28, 2019
| @@ -9,6 +9,8 @@ | |||
| #include <utility> | |||
| #include <vector> | |||
|
|
|||
| #include "base/memory/ptr_util.h" | |||
| #include "base/strings/utf_string_conversions.h" | |||
There was a problem hiding this comment.
For base::UTF8ToUTF16 and base::UTF16ToUTF8.
alexeykuzmin
commented
Aug 28, 2019
| @@ -9,6 +9,8 @@ | |||
| #include <utility> | |||
| #include <vector> | |||
|
|
|||
| #include "base/memory/ptr_util.h" | |||
There was a problem hiding this comment.
For base::WrapUnique.
miniak
approved these changes
Aug 28, 2019
ckerr
approved these changes
Aug 28, 2019
jkleinsc
approved these changes
Aug 28, 2019
zcbenz
approved these changes
Aug 29, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A follow-up for #19698.
Checklist
npm testpassesRelease Notes
Notes: no-notes