fix: ensure popup and closepopup are threaded correctly #20114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #19411.
Previously, we called
base::PostTaskWithTraits
onmenu.popup()
, which meant that we would encounter a race condition withmenu.closePopup()
if it was called too soon aftermenu.popup()
; thewindow_id
would not yet have been added topopup_controllers_
and thus it would not be able to find the menu to close.This fixes that race condition by posting
menu.closePopup()
to the current sequence to ensure that thepopup
task had finished running before other tasks are run.cc @nornagon @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
menu.closePopup()
would have no effect if called too soon aftermenu.popup()
.