feat: allow Linux/Windows users to set notification timeout #20153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
linux-notif-timeout
branch
3 times, most recently
from
9498433
to
04060e8
Compare
codebytere
changed the title
codebytere
force-pushed
the
linux-notif-timeout
branch
from
04060e8
to
346634c
Compare
jkleinsc
requested changes
Sep 11, 2019
codebytere
force-pushed
the
linux-notif-timeout
branch
2 times, most recently
from
ebe5752
to
0806aee
Compare
jkleinsc
approved these changes
Sep 17, 2019
miniak
reviewed
Sep 19, 2019
3 tasks
codebytere
force-pushed
the
linux-notif-timeout
branch
from
d599c15
to
8555889
Compare
codebytere
force-pushed
the
linux-notif-timeout
branch
from
8555889
to
af01fa7
Compare
miniak
approved these changes
Oct 9, 2019
|
Release Notes Persisted
|
There was a problem hiding this comment.
Looks good to me, but I'd call out that using the reminder scenario will force a notification sound to be played (the reminder sound, to be precise).
I'm not sure if setting the notification to silent actually overrides that behavior.
Either way, solid addition!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #12458.
Allows users to set timeout type of Linux and Windows notifications - either
defaultornever.cc @ckerr
Checklist
npm testpassesRelease Notes
Notes: Added
timeoutTypeproperty to allows users to set timeout type for Linux and Windows notifications.