fix: Make the --disable-color-correct-rendering switch work again
#20356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke in Electron 6 due to some Chromium changes. Test Plan: - Confirm that test case from electron#15898 (comment) now works Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
|
If it's a Chromium flag, would it make sense to fix it upstream? |
|
@alexeykuzmin Unfortunately Chromium removed this flag a long time ago (see #15898 for context) so it's unlikely that they will accept the patch. |
alexeykuzmin
approved these changes
Sep 27, 2019
poiru
added a commit
to poiru/electron
that referenced
this pull request
Sep 27, 2019
…backport) This is a manual backport of electron#20356 Notes: Fix disabling color correct rendering with --disable-color-correct-rendering
poiru
added a commit
to poiru/electron
that referenced
this pull request
Sep 27, 2019
…backport) This is a manual backport of electron#20356 Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
poiru
added a commit
to poiru/electron
that referenced
this pull request
Sep 27, 2019
…backport) Backport of electron#20356 Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
poiru
added a commit
to poiru/electron
that referenced
this pull request
Sep 27, 2019
…backport) Backport of electron#20356 Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
nornagon
approved these changes
Sep 30, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke in Electron 6 due to some Chromium changes.
Test Plan:
Release Notes
Notes: Fix disabling color correct rendering with
--disable-color-correct-rendering