feat: allow inspection of specific shared workers #20389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Replaces #19793 |
miniak
requested review from
zcbenz,
MarshallOfSound,
jkleinsc and
alexeykuzmin
miniak
force-pushed
the
miniak/shared-worker
branch
from
6eae077
to
64c3e43
Compare
alexeykuzmin
approved these changes
Oct 1, 2019
jkleinsc
approved these changes
Oct 1, 2019
zcbenz
approved these changes
Oct 2, 2019
|
Release Notes Persisted
|
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added APIs to allow electron to get a list of shared web workers and then inspect
a shared worker based on its ID.
Checklist
npm testpassesRelease Notes
Notes: Added ability to inspect specific shared workers:
contents.getAllSharedWorkers()/contents.inspectSharedWorkerById(workerId).