Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added Drag and drop files Fiddle example #20472

Merged
merged 1 commit into from Oct 21, 2019
Merged

docs: Added Drag and drop files Fiddle example #20472

merged 1 commit into from Oct 21, 2019

Conversation

yashints
Copy link
Contributor

@yashints yashints commented Oct 8, 2019

Description of Change

Refs #20442

Adds the Drag and Drop files example from electron-api-demos into a runnable Fiddle example.

Checklist

  • PR description included and stakeholders cc'd
  • standard linter passes
  • PR title follows semantic commit guidelines

Release Notes

notes: Added the Drag and Drop files example from electron-api-demos into a runnable Fiddle example.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 8, 2019
@erickzhao erickzhao mentioned this pull request Oct 10, 2019
Closed
50 tasks
erickzhao
erickzhao suggested changes Oct 10, 2019
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed to publish this. :)

docs/fiddles/native-ui/drag-and-drop/main.js Outdated Show resolved Hide resolved
docs/fiddles/native-ui/drag-and-drop/index.html Outdated Show resolved Hide resolved
docs/fiddles/native-ui/drag-and-drop/index.html Outdated Show resolved Hide resolved
docs/fiddles/native-ui/drag-and-drop/index.html Outdated Show resolved Hide resolved
docs/fiddles/native-ui/drag-and-drop/index.html Outdated Show resolved Hide resolved
docs/fiddles/native-ui/drag-and-drop/index.html Outdated Show resolved Hide resolved
codebytere
codebytere approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good following changes!

@zcbenz zcbenz merged commit 4e88633 into electron:master Oct 21, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2019

Release Notes Persisted

Added the Drag and Drop files example from electron-api-demos into a runnable Fiddle example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao requested changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yashints @zcbenz @codebytere @erickzhao