Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate breakpad symbols before stripping #20530

Merged
merged 2 commits into from Oct 14, 2019
Merged

Conversation

nornagon
Copy link
Member

Description of Change

Looks like at some point we switched the order of strip and generate symbols, meaning we have been producing near-useless Linux symbols for some time now. (Afaict the symbols for Electron v5 are OK, but the v6 ones are broken.)

Checklist

Release Notes

Notes: Fixed debug symbol files on linux not containing private symbols.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 10, 2019
@jkleinsc
Copy link
Contributor

Release builds here:
CircleCI release build request for linux-arm64-publish successful. Check https://circleci.com/gh/electron/electron/353712 for status.
CircleCI release build request for linux-x64-publish successful. Check https://circleci.com/gh/electron/electron/353715 for status.
CircleCI release build request for linux-arm-publish successful. Check https://circleci.com/gh/electron/electron/353711 for status.
CircleCI release build request for mas-publish successful. Check https://circleci.com/gh/electron/electron/353716 for status.
CircleCI release build request for osx-publish successful. Check https://circleci.com/gh/electron/electron/353714 for status.
CircleCI release build request for linux-ia32-publish successful. Check https://circleci.com/gh/electron/electron/353713 for status.

@jkleinsc
Copy link
Contributor

Release builds running here:
CircleCI release build request for linux-ia32-publish successful. Check https://circleci.com/gh/electron/electron/354516 for status.
CircleCI release build request for mas-publish successful. Check https://circleci.com/gh/electron/electron/354514 for status.
CircleCI release build request for linux-arm64-publish successful. Check https://circleci.com/gh/electron/electron/354517 for status.
CircleCI release build request for linux-arm-publish successful. Check https://circleci.com/gh/electron/electron/354515 for status.
CircleCI release build request for osx-publish successful. Check https://circleci.com/gh/electron/electron/354518 for status.
CircleCI release build request for linux-x64-publish successful. Check https://circleci.com/gh/electron/electron/354519 for status.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2019
@nornagon
Copy link
Member Author

Seems to be working—the symbol files are now ~80MB instead of ~800KB.

@jkleinsc
Copy link
Contributor

Merging as CI failures unrelated to change.

@jkleinsc jkleinsc merged commit 6025ae7 into master Oct 14, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 14, 2019

Release Notes Persisted

Fixed debug symbol files on linux not containing private symbols.

@jkleinsc jkleinsc deleted the fix-linux-symbols branch October 14, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants