From b7dff4436e95904cbd91f83178351c210a833ee5 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Thu, 10 Oct 2019 13:18:47 -0700 Subject: [PATCH 1/2] fix: generate breakpad symbols before stripping --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7206bf786f270..03f760a62b93e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -953,10 +953,10 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish # Electron app - *step-electron-build + - *step-maybe-generate-breakpad-symbols - *step-maybe-electron-dist-strip - *step-electron-dist-build - *step-electron-dist-store - - *step-maybe-generate-breakpad-symbols - *step-maybe-zip-symbols # mksnapshot From 50b01a6d503819cf470a5b7bfe0b1aa2fb4e372d Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Fri, 11 Oct 2019 10:24:43 -0700 Subject: [PATCH 2/2] store symbols as circleci artifacts --- .circleci/config.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 03f760a62b93e..74357441127d0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -553,6 +553,11 @@ step-maybe-zip-symbols: &step-maybe-zip-symbols ninja -C out/Default electron:electron_version electron/script/zip-symbols.py -b $BUILD_PATH +step-symbols-store: &step-symbols-store + store_artifacts: + path: src/out/Default/symbols.zip + destination: symbols.zip + step-maybe-cross-arch-snapshot: &step-maybe-cross-arch-snapshot run: name: Generate cross arch snapshot (arm/arm64) @@ -859,6 +864,7 @@ steps-electron-build: &steps-electron-build - *step-maybe-generate-breakpad-symbols - *step-maybe-zip-symbols + - *step-symbols-store # Trigger tests on arm hardware if needed - *step-maybe-trigger-arm-test @@ -933,6 +939,7 @@ steps-electron-build-with-inline-checkout-for-tests: &steps-electron-build-with- - *step-maybe-generate-breakpad-symbols - *step-maybe-zip-symbols + - *step-symbols-store # Trigger tests on arm hardware if needed - *step-maybe-trigger-arm-test @@ -958,6 +965,7 @@ steps-electron-build-for-publish: &steps-electron-build-for-publish - *step-electron-dist-build - *step-electron-dist-store - *step-maybe-zip-symbols + - *step-symbols-store # mksnapshot - *step-mksnapshot-build