Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not manually parse content-type #20538

Merged
merged 1 commit into from Oct 11, 2019
Merged

fix: do not manually parse content-type #20538

merged 1 commit into from Oct 11, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Oct 11, 2019

Description of Change

Close #20182.

This PR fixes invalid mime type being set caused by manually parsing the content-type header.

Checklist

Release Notes

Notes: Fix setting content-type header with charset breaking protocol APIs.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2019
@jkleinsc jkleinsc added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 11, 2019
@jkleinsc jkleinsc merged commit 1b2c6a3 into master Oct 11, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 11, 2019

Release Notes Persisted

Fix setting content-type header with charset breaking protocol APIs.

@jkleinsc jkleinsc deleted the fix-content-type-charset branch October 11, 2019 18:54
@trop trop bot mentioned this pull request Oct 11, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Oct 11, 2019

I have automatically backported this PR to "7-0-x", please check out #20544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content type charset headers break registerStreamProtocol api
3 participants
@zcbenz @nornagon @jkleinsc