fix: append network switches to network service process #20546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
added
fast-track 🚅
MarshallOfSound
approved these changes
Oct 11, 2019
codebytere
approved these changes
Oct 12, 2019
zcbenz
approved these changes
Oct 14, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "7-0-x", please check out #20558 |
deepak1556
added a commit
that referenced
this pull request
Mar 27, 2020
deepak1556
added a commit
that referenced
this pull request
Mar 27, 2020
6 tasks
deepak1556
added a commit
that referenced
this pull request
Mar 27, 2020
deepak1556
added a commit
that referenced
this pull request
Mar 31, 2020
deepak1556
added a commit
that referenced
this pull request
Apr 1, 2020
…2917) * fix: ensure standard schemes are registered in nw service process Refs #20546 * chore: add test * chore: apply suggestions from code review Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 7, 2020
…ectron#22867) * fix: ensure standard schemes are registered in nw service process Refs electron#20546 * chore: add test * chore: apply suggestions from code review Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org> Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Forward switches related to privileged schemes in network service process, otherwise will lead to service crash <-> restart infinite loop. Gets rid of the error message
VALIDATION_ERROR_DESERIALIZATION_FAILEDwe have been seeing since the service was enabled.Thanks to @nornagon who helped with debugging this issue.
Fixes #20517
Checklist
npm testpassesRelease Notes
Notes: fix memory leak when using protocol.registerSchemeAsPrivileged api