fix: macOS getColor inconsistencies #20611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-set-color
branch
3 times, most recently
from
072fe7c
to
9bd224b
Compare
codebytere
force-pushed
the
fix-set-color
branch
3 times, most recently
from
3af6005
to
6100e99
Compare
Co-Authored-By: Samuel Attard <sattard@slack-corp.com>
codebytere
force-pushed
the
fix-set-color
branch
from
e0ea383
to
d3806c9
Compare
MarshallOfSound
approved these changes
Oct 21, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #20599.
Updates documentation to reflect macOS 10.14 specific colors and fixes a mistyped color. Also notes a deprecated color.
cc @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Fixed some
systemPreferences.getColor()inconsistencies on macOS.