Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overwrite global constructor names in remote #20637

Merged
merged 2 commits into from Oct 21, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Oct 18, 2019

Description of Change

This was causing an issue where the name of the Object constructor could be overwritten to Error, causing bizarre behavior like console.log({}) printing Error {}.

Checklist

Release Notes

Notes: Fixed an issue in the remote module which could cause the name of the Object constructor to be overwritten globally.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2019
@nornagon nornagon requested a review from miniak October 18, 2019 18:32
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 19, 2019
@zcbenz zcbenz merged commit b155ebe into master Oct 21, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2019

Release Notes Persisted

Fixed an issue in the remote module which could cause the name of the Object constructor to be overwritten globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants