From 9f9b994bb0bb86d67e723cb6d987848e6bb599cf Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 29 Oct 2019 11:57:19 -0700 Subject: [PATCH] fix: do not DCHECK non-const methods --- shell/renderer/atom_renderer_client.cc | 4 +++- shell/renderer/web_worker_observer.cc | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/shell/renderer/atom_renderer_client.cc b/shell/renderer/atom_renderer_client.cc index 0f2ad68db6bca..523eb81bf7a9a 100644 --- a/shell/renderer/atom_renderer_client.cc +++ b/shell/renderer/atom_renderer_client.cc @@ -121,7 +121,9 @@ void AtomRendererClient::DidCreateScriptContext( node::tracing::TraceEventHelper::SetAgent(node::CreateAgent()); // Setup node environment for each window. - DCHECK(node::InitializeContext(renderer_context)); + bool initialized = node::InitializeContext(renderer_context); + CHECK(initialized); + node::Environment* env = node_bindings_->CreateEnvironment(renderer_context, nullptr, true); diff --git a/shell/renderer/web_worker_observer.cc b/shell/renderer/web_worker_observer.cc index 5e10ac8244c22..ffc9d2f8b6676 100644 --- a/shell/renderer/web_worker_observer.cc +++ b/shell/renderer/web_worker_observer.cc @@ -48,7 +48,8 @@ void WebWorkerObserver::ContextCreated(v8::Local worker_context) { node_bindings_->PrepareMessageLoop(); // Setup node environment for each window. - DCHECK(node::InitializeContext(worker_context)); + bool initialized = node::InitializeContext(worker_context); + CHECK(initialized); node::Environment* env = node_bindings_->CreateEnvironment(worker_context, nullptr, true);