Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate <webview>.getWebContents() #21039

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 7, 2019

Backport of #20726

See that PR for details.

Notes: Deprecated <webview>.getWebContents() as it depends on the remote module.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 7, 2019
@trop trop bot mentioned this pull request Nov 7, 2019
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Nov 7, 2019
@jkleinsc
Copy link
Contributor

jkleinsc commented Nov 7, 2019

Merging as CI failures unrelated to doc change.

@jkleinsc jkleinsc merged commit 1913926 into 8-x-y Nov 7, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 7, 2019

Release Notes Persisted

Deprecated <webview>.getWebContents() as it depends on the remote module.

@jkleinsc jkleinsc deleted the trop/8-x-y-bp-feat-deprecate-webview-getwebcontents--1573148625698 branch November 7, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants