Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor printing for mojo #21059

Merged
merged 1 commit into from Nov 13, 2019
Merged

fix: refactor printing for mojo #21059

merged 1 commit into from Nov 13, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 9, 2019 •
edited by miniak

Description of Change

Backport of #21026.

See that PR for more details.

Checklist

Release Notes

Notes: Fixed printing.

@codebytere codebytere requested a review from a team as a code owner November 9, 2019 02:55
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 9, 2019
@trop trop bot mentioned this pull request Nov 9, 2019
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Nov 9, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 9, 2019
jkleinsc
jkleinsc approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere merged commit 8d67f16 into 8-x-y Nov 13, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 13, 2019

Release Notes Persisted

Fixed printing.

@codebytere codebytere deleted the mojo-print-refactor-bp branch November 13, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc