Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add app.getApplicationNameForProtocol API (8-x-y) #21117

Merged
merged 1 commit into from Nov 14, 2019
Merged

feat: add app.getApplicationNameForProtocol API (8-x-y) #21117

merged 1 commit into from Nov 14, 2019

Conversation

ajmacd
Copy link
Contributor

@ajmacd ajmacd commented Nov 13, 2019 •
edited

Backport of #20399

Approved by the Releases WG: #20399 (comment)

notes: Added app.getApplicationNameForProtocol() API

@ajmacd
feat: add app.getApplicationNameForProtocol API (electron#20399)
6656683 
* Add GetApplicationNameForProtocol.

* Fix Windows implementation.

* Fix up test.

* Add documentation.

* Implement for real on Linux using xdg-mime.

Also ensure we allow blocking calls here to avoid errant DCHECKing.

* Improve docs for Linux.

* Clean up tests.

* Add a note about not relying on the precise format.

* Update docs/api/app.md

Co-Authored-By: Shelley Vohr <codebytere@github.com>

* Remove needless `done()`s from tests.

* Use vector list initialization.

* Add a simple test for isDefaultProtocolClient.

* Remove unneeded include and skip a test on Linux CI.

* We no longer differentiate between CI and non-CI test runs.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 13, 2019
@trop trop bot mentioned this pull request Nov 13, 2019
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Nov 13, 2019
codebytere
codebytere approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the API WG and the Releases WG given votes that have been passed for this PR.

@jkleinsc jkleinsc merged commit a4ef2d4 into electron:8-x-y Nov 14, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 14, 2019

Release Notes Persisted

Added app.getApplicationNameForProtocol() API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajmacd @codebytere @jkleinsc