Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation warning for the default of allowRendererProcessReuse #21287

Merged
merged 2 commits into from Nov 26, 2019

Conversation

MarshallOfSound
Copy link
Member

Refs: #18397

This is the 8-x-y step that is required in that issue's timeline.

Notes: Deprecated the default value of app.allowRendererProcessReuse (See #18397)

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 26, 2019
lib/browser/api/web-contents.js Show resolved Hide resolved
@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Nov 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 26, 2019
@MarshallOfSound MarshallOfSound merged commit 41e64d2 into 8-x-y Nov 26, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 26, 2019

Release Notes Persisted

Deprecated the default value of app.allowRendererProcessReuse (See #18397)

@MarshallOfSound MarshallOfSound deleted the deprecate-rpr-default branch November 26, 2019 23:48
@sofianguy sofianguy added this to Fixed in 8.0.0-beta.4 in 8.2.x Dec 9, 2019
kittaakos pushed a commit to eclipse-theia/theia that referenced this pull request Aug 11, 2020
kittaakos pushed a commit to eclipse-theia/theia that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
No open projects
8.2.x
Fixed in 8.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

2 participants