Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when doing redirect navigation with webRequest listener (8-x-y) #21841

Merged
merged 2 commits into from Jan 22, 2020
Merged

fix: crash when doing redirect navigation with webRequest listener (8-x-y) #21841

merged 2 commits into from Jan 22, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Jan 21, 2020

Backport of #21838.

Notes: Fix crash when doing redirect navigation with webRequest listener.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 21, 2020
@trop trop bot mentioned this pull request Jan 21, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jan 21, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 21, 2020
@zcbenz zcbenz merged commit 71a31d5 into 8-x-y Jan 22, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2020

Release Notes Persisted

Fix crash when doing redirect navigation with webRequest listener.

@zcbenz zcbenz deleted the web-request-http-request-crash-8-x-y branch January 22, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @deepak1556