New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Exposing methods required by capturing a hidden webContents #21895
feat: Exposing methods required by capturing a hidden webContents #21895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Features can not be backported to older release lines without approval from @electron/wg-releases
@LuoJinghua I have added this to next wg-releases meeting's agenda, but we need to have a strong reason when backporting a new feature. Can you explain why you want to backport this feature? |
Hi @zcbenz, Our product shows a wall of browsers, user can click one of them to show the browser window and then hide the window. The product need this API to function correctly without any other workaround. We really don't want to depend on the electron nightly or build a custom version of electron from stable branch. These methods existed for a long time and just isn't exposed. Without this backport, we have to a build custom version of electron until electron-9 become stable. |
3c6c77e
to
11d0ac0
Compare
The @electron/wg-releases WG has decided that this feature is too late to make it into the 8-0-x release. It will be included in a 8-1-x release if the decision is made to issue a 8-1-x release. We are going to move this PR to a WIP status in the meantime. |
This feature was re-visited by the @electron/wg-releases on 31/01/2020 and approved for merge to |
Release Notes Persisted
|
Description of Change
Backport of #21679 for the 8-x-y branch.
Release Notes
Notes: Exposing methods required by capturing a hidden webContents
@zcbenz