Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show module name in deprecation warning for context-aware modules #21958

Merged
merged 1 commit into from Jan 30, 2020
Merged

fix: show module name in deprecation warning for context-aware modules #21958

merged 1 commit into from Jan 30, 2020

Conversation

nornagon
Copy link
Member

Backport of #21952, see that change for details.

Notes: Added name of module to context-aware deprecation warning (#18397).

@nornagon nornagon requested a review from a team as a code owner January 29, 2020 19:41
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 29, 2020
@trop trop bot mentioned this pull request Jan 29, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jan 29, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 29, 2020
@MarshallOfSound MarshallOfSound merged commit 048d770 into 8-x-y Jan 30, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2020

Release Notes Persisted

Added name of module to context-aware deprecation warning (#18397).

@MarshallOfSound MarshallOfSound deleted the backport/8-x-y/context-aware-deprecation branch January 30, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @jkleinsc @MarshallOfSound