fix: compilation of native modules on windows with older msvc versions #21960

deepak1556 · 2020-01-29T21:18:23Z

Backports #21950

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: fix compilation error for native modules building with VS 2015

release-clerk · 2020-01-30T01:13:11Z

Release Notes Persisted

fix compilation error for native modules building with VS 2015

fix: compilation of native modules on windows with older msvc versions (

05f7c23

#21950)

deepak1556 requested a review from a team as a code owner January 29, 2020 21:18

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 29, 2020

trop bot mentioned this pull request Jan 29, 2020

fix: compilation of native modules on windows with older msvc versions #21950

Merged

6 tasks

trop bot added 8-x-y backport This is a backport PR labels Jan 29, 2020

nornagon approved these changes Jan 29, 2020

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 29, 2020

MarshallOfSound approved these changes Jan 29, 2020

View reviewed changes

MarshallOfSound merged commit b3fdb24 into 8-x-y Jan 30, 2020

MarshallOfSound deleted the robo/fix_deprecated_win_8_x branch January 30, 2020 01:13

Provide feedback