Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent print crash on bad deviceName #21982

Merged
merged 2 commits into from Jan 31, 2020
Merged

fix: prevent print crash on bad deviceName #21982

merged 2 commits into from Jan 31, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 31, 2020

Backport of #21946

See that PR for details.

Notes: Fixed a potential crash on faulty deviceNames in webContents.print().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2020
@trop trop bot requested a review from codebytere January 31, 2020 02:49
@trop trop bot mentioned this pull request Jan 31, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jan 31, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2020
@codebytere codebytere merged commit 63bcbd4 into 8-x-y Jan 31, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2020

Release Notes Persisted

Fixed a potential crash on faulty deviceNames in webContents.print().

@codebytere codebytere deleted the trop/8-x-y-bp-fix-prevent-print-crash-on-bad-devicename-1580438972553 branch January 31, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere