feat: allow setting code cache directory #31154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
miniak
force-pushed
the
miniak/code-cache-path
branch
3 times, most recently
from
a7e1b10
to
90ea368
Compare
nornagon
reviewed
Mar 3, 2022
nornagon
reviewed
Mar 3, 2022
nornagon
reviewed
Mar 3, 2022
|
API LGTM |
deepak1556
force-pushed
the
miniak/code-cache-path
branch
from
90ea368
to
a57159b
Compare
ckerr
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Looks like a good idea.
From an API WG pov, my two questions are
-
Does it make sense to expose the size feature to end users? It looks like it would be easy to do, but IDK if there's benefit in it.
-
The previous discussion about what to do with dead cache entries
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
There are three approvals, so this bot being broken is not a reason to block this PR |
|
Release Notes Persisted
|
This was referenced Mar 15, 2022
|
I have automatically backported this PR to "17-x-y", please check out #33285 |
|
I have automatically backported this PR to "18-x-y", please check out #33286 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
* feat: allow setting code cache directory * chore: address review feedback * chore: update docs Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: rewrite with base::Contains Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: allow setting code cache directory * chore: address review feedback * chore: update docs Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: rewrite with base::Contains Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add
ses.setCodeCachePath()API for setting code cache directory.When transitioning to a node-free renderer environment apps which previously relied on creating v8 cached data via the vm module would store the data at version based locations of the format like
<user-data-dir>/<commit-sha-or-version>so that the cache can be invalidated on updates. When relying on blink to now handle the cache creation and invalidation, this api is useful to serve as a hard reset when the cache goes into a non-recoverable state.Checklist
npm testpassesRelease Notes
Notes: Added
ses.setCodeCachePath()API for setting code cache directory.