feat: add WCO height option #31222

mlaurencin · 2021-10-01T00:09:58Z

Description of Change

This PR adds a height option to the Windows and macOS implementations of the Window Controls Overlay. See this other PR for the initial implementations. The height specified is in pixels.

Current Issues:

Adding docs
Fixing macOS button placement

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Added height option for Windows Control Overlay

MarshallOfSound · 2021-10-06T23:08:20Z

Would a macOS compatible height option also be something of interest?

Yes 👍 😆

shell/browser/native_window_mac.mm

ckerr

with my wg-api hat on... looks like the only API change is the new optional height integer, is that correct?

jkleinsc

Documentation needs to be updated to reflect change applies to macOS as well.

docs/api/browser-window.md

shell/browser/native_window.cc

shell/browser/ui/views/win_frame_view.cc

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

shell/browser/native_window_mac.mm

zcbenz

API LGTM

jkleinsc

Mac traffic light position is not correct (this was tested with height of 50):

trop · 2022-02-17T03:20:21Z

@mlaurencin has manually backported this PR to "17-x-y", please check out #32939

* feat: add WCO height option * add docs and mac functionality * add macOS functionality and height lowerbound * Update docs/api/browser-window.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * update macOS functionality * add chromium related notes * add test and fix pixel under button bug and fix typo * revert changes to docs/api/frameless-window.md * modify `useCustomHeight` calls * update `useCustomHeight` and `getCurrentMargin` * modify margin calculation * fix minimum custom height on macOS * Update window_buttons_proxy.mm * fix specified traffic light positions Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* feat: add WCO height option * add docs and mac functionality * add macOS functionality and height lowerbound * Update docs/api/browser-window.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * update macOS functionality * add chromium related notes * add test and fix pixel under button bug and fix typo * revert changes to docs/api/frameless-window.md * modify `useCustomHeight` calls * update `useCustomHeight` and `getCurrentMargin` * modify margin calculation * fix minimum custom height on macOS * Update window_buttons_proxy.mm * fix specified traffic light positions Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

trop · 2022-02-23T22:23:56Z

@mlaurencin has manually backported this PR to "16-x-y", please check out #33061

* feat: add WCO height option * add docs and mac functionality * add macOS functionality and height lowerbound * Update docs/api/browser-window.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * update macOS functionality * add chromium related notes * add test and fix pixel under button bug and fix typo * revert changes to docs/api/frameless-window.md * modify `useCustomHeight` calls * update `useCustomHeight` and `getCurrentMargin` * modify margin calculation * fix minimum custom height on macOS * Update window_buttons_proxy.mm * fix specified traffic light positions Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

trop · 2022-02-23T22:45:23Z

@mlaurencin has manually backported this PR to "15-x-y", please check out #33064

trop · 2022-02-23T23:54:57Z

@mlaurencin has manually backported this PR to "14-x-y", please check out #33065

* feat: add WCO height option (#31222) * feat: add WCO height option * add docs and mac functionality * add macOS functionality and height lowerbound * Update docs/api/browser-window.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * update macOS functionality * add chromium related notes * add test and fix pixel under button bug and fix typo * revert changes to docs/api/frameless-window.md * modify `useCustomHeight` calls * update `useCustomHeight` and `getCurrentMargin` * modify margin calculation * fix minimum custom height on macOS * Update window_buttons_proxy.mm * fix specified traffic light positions Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * Update win_caption_button.h * Update win_caption_button_container.h Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

feat: add WCO height option

2d3f64c

mlaurencin added the wip ⚒ label Oct 1, 2021

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 1, 2021

mlaurencin added api-review/requested 🗳 backport/requested 🗳 semver/minor backwards-compatible functionality target/13-x-y labels Oct 4, 2021

mlaurencin removed the backport/requested 🗳 label Oct 6, 2021

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 8, 2021

mlaurencin added 2 commits October 12, 2021 11:24

add docs and mac functionality

4fce4a4

add macOS functionality and height lowerbound

47a9ac2

mlaurencin marked this pull request as ready for review October 15, 2021 06:09

mlaurencin removed the wip ⚒ label Oct 15, 2021

zcbenz reviewed Oct 19, 2021

View reviewed changes

shell/browser/native_window_mac.mm Show resolved Hide resolved

ckerr reviewed Oct 19, 2021

View reviewed changes

jkleinsc requested changes Oct 19, 2021

View reviewed changes

docs/api/browser-window.md Outdated Show resolved Hide resolved

ckerr reviewed Oct 19, 2021

View reviewed changes

shell/browser/native_window.cc Show resolved Hide resolved

shell/browser/ui/views/win_frame_view.cc Outdated Show resolved Hide resolved

shell/browser/ui/views/win_frame_view.cc Show resolved Hide resolved

Update docs/api/browser-window.md

93fe25f

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

zcbenz requested changes Oct 20, 2021

View reviewed changes

shell/browser/native_window_mac.mm Show resolved Hide resolved

mlaurencin added 5 commits November 8, 2021 14:13

update macOS functionality

a97d42b

add chromium related notes

1027b0c

add test and fix pixel under button bug and fix typo

7016775

revert changes to docs/api/frameless-window.md

a58a569

modify useCustomHeight calls

dc1fd0c

zcbenz approved these changes Nov 10, 2021

View reviewed changes

update useCustomHeight and getCurrentMargin

d9fa2eb

jkleinsc requested changes Nov 15, 2021

View reviewed changes

mlaurencin mentioned this pull request Feb 17, 2022

feat: add WCO height option #32939

Merged

trop bot added the in-flight/17-x-y label Feb 17, 2022

trop bot added merged/17-x-y and removed in-flight/17-x-y labels Feb 22, 2022

mlaurencin mentioned this pull request Feb 23, 2022

feat: add WCO height option #33061

Merged

trop bot added in-flight/16-x-y and removed needs-manual-bp/16-x-y labels Feb 23, 2022

mlaurencin mentioned this pull request Feb 23, 2022

feat: add WCO height option #33064

Merged

trop bot added in-flight/15-x-y and removed needs-manual-bp/15-x-y labels Feb 23, 2022

mlaurencin mentioned this pull request Feb 23, 2022

feat: add WCO height option #33065

Closed

trop bot added in-flight/14-x-y and removed needs-manual-bp/14-x-y labels Feb 23, 2022

trop bot added merged/16-x-y and removed in-flight/16-x-y labels Feb 28, 2022

commit-lint bot mentioned this pull request Mar 29, 2022

[pull] main from electron:main Blaquez-home/electron#3

Open

mlaurencin mentioned this pull request May 18, 2022

docs: add height option and color transparency info #34278

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add WCO height option #31222

feat: add WCO height option #31222

mlaurencin commented Oct 1, 2021 •

edited

MarshallOfSound commented Oct 6, 2021

ckerr left a comment

jkleinsc left a comment

zcbenz left a comment

jkleinsc left a comment

trop bot commented Feb 17, 2022

trop bot commented Feb 23, 2022

trop bot commented Feb 23, 2022

trop bot commented Feb 23, 2022

feat: add WCO height option #31222

feat: add WCO height option #31222

Conversation

mlaurencin commented Oct 1, 2021 • edited

Description of Change

Checklist

Release Notes

MarshallOfSound commented Oct 6, 2021

ckerr left a comment

Choose a reason for hiding this comment

jkleinsc left a comment

Choose a reason for hiding this comment

zcbenz left a comment

Choose a reason for hiding this comment

jkleinsc left a comment

Choose a reason for hiding this comment

trop bot commented Feb 17, 2022

trop bot commented Feb 23, 2022

trop bot commented Feb 23, 2022

trop bot commented Feb 23, 2022

mlaurencin commented Oct 1, 2021 •

edited