feat: support more color formats for backgroundColor
#31868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
BlackHole1
reviewed
Nov 18, 2021
miniak
approved these changes
Nov 19, 2021
|
API LGTM |
codebytere
force-pushed
the
support-more-color-formats
branch
2 times, most recently
from
e5097a6
to
7c84127
Compare
nornagon
requested changes
Jan 18, 2022
codebytere
force-pushed
the
support-more-color-formats
branch
2 times, most recently
from
c2dcb17
to
f797a7a
Compare
nornagon
reviewed
Jan 20, 2022
nornagon
reviewed
Jan 20, 2022
nornagon
reviewed
Jan 20, 2022
codebytere
added
semver/major
ckerr
reviewed
Feb 3, 2022
codebytere
force-pushed
the
support-more-color-formats
branch
from
f797a7a
to
6790e31
Compare
|
Discussed with the API WG and we'll keep the ARGB format to avoid breaking existing apps, and drop the format option from getBackgroundColor. |
codebytere
force-pushed
the
support-more-color-formats
branch
from
6790e31
to
7186b9d
Compare
codebytere
force-pushed
the
support-more-color-formats
branch
from
42a82c0
to
4987a7a
Compare
nornagon
reviewed
Mar 16, 2022
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
nornagon
reviewed
Mar 16, 2022
nornagon
reviewed
Mar 16, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "18-x-y", please check out #33364 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #31019.
In #30193, we unintentionally refactored
WebPreferencessuch thatbackgroundColorno longer accepted CSS color values likered. However, that only worked for some types ofbackgroundColormethods, since others did enforce that the passed value be hex.This PR thus adds more official support for the following formats:
And as a bonus removes some duplicate code from our
color_utilfile.Checklist
npm testpassesRelease Notes
Notes: Added support for more color formats in
setBackgroundColor.