New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Substitutions menu roles on macOS #32024
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
API LGTM |
API LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Congrats on merging your first pull request! 🎉🎉🎉 |
Release Notes Persisted
|
Description of Change
Chromium has supported macOS text substitutions for some time now. They already work in Electron, but there was no way to control them from the menubar like in native Mac apps.
This PR exposes the necessary menu roles, and also adds a default Edit > Substitutions menu on macOS.
Fixes #15535.
Checklist
npm test
passesRelease Notes
Notes: Added Substitutions menu roles on macOS:
showSubstitutions
,toggleSmartQuotes
,toggleSmartDashes
,toggleTextReplacement
.