New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gtk_native_dialog_run() calls show() internally #32049
Conversation
In the synchronous code path, gtk_native_dialog_run() will call gtk_native_dialog_show(). Previously this was causing an assertion to be hit at run time.
This should be backported to all Electron versions >= 14.0.0 and released immediately. What is the process for that? Do I need to submit the PRs? |
cc @zcbenz, @MarshallOfSound, & @electron/wg-api <-- how to do a team mention? |
Assuming electron run its tests in CI, it would be useful to test against fedora:latest since it will have a version of gtk3 that should trigger the correct code paths. |
Failure seems unrelated. |
Release Notes Persisted
|
I have automatically backported this PR to "14-x-y", please check out #32080 |
I have automatically backported this PR to "15-x-y", please check out #32081 |
I have automatically backported this PR to "16-x-y", please check out #32082 |
I have automatically backported this PR to "17-x-y", please check out #32083 |
In the synchronous code path, gtk_native_dialog_run() will call gtk_native_dialog_show(). Previously this was causing an assertion to be hit at run time.
Description of Change
In the synchronous code path, gtk_native_dialog_run() will call
gtk_native_dialog_show(). Previously this was causing an assertion to be
hit at run time.
https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.30/gtk/gtknativedialog.c#L584
fixes #31997
Checklist
npm test
passesRelease Notes
Notes: Assertion failure happening in the
showSaveDialogSync()
code path has been fixed. (Fixes #31997)