Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gtk_native_dialog_run() calls show() internally #32049

Merged
merged 1 commit into from Dec 2, 2021
Merged

fix: gtk_native_dialog_run() calls show() internally #32049

merged 1 commit into from Dec 2, 2021

Conversation

tristan957
Copy link
Contributor

@tristan957 tristan957 commented Nov 29, 2021

Description of Change

In the synchronous code path, gtk_native_dialog_run() will call
gtk_native_dialog_show(). Previously this was causing an assertion to be
hit at run time.

https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.30/gtk/gtknativedialog.c#L584

fixes #31997

Checklist

Release Notes

Notes: Assertion failure happening in the showSaveDialogSync() code path has been fixed. (Fixes #31997)

In the synchronous code path, gtk_native_dialog_run() will call
gtk_native_dialog_show(). Previously this was causing an assertion to be
hit at run time.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 29, 2021
@tristan957
Copy link
Contributor Author

tristan957 commented Nov 29, 2021

This should be backported to all Electron versions >= 14.0.0 and released immediately. What is the process for that? Do I need to submit the PRs?

@tristan957
Copy link
Contributor Author

tristan957 commented Nov 29, 2021

cc @zcbenz, @MarshallOfSound, & @electron/wg-api <-- how to do a team mention?

@tristan957
Copy link
Contributor Author

Assuming electron run its tests in CI, it would be useful to test against fedora:latest since it will have a version of gtk3 that should trigger the correct code paths.

@tristan957
Copy link
Contributor Author

Failure seems unrelated.

@MarshallOfSound MarshallOfSound added target/14-x-y semver/patch backwards-compatible bug fixes labels Nov 29, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 30, 2021
@deepak1556 deepak1556 merged commit eabfd6c into electron:main Dec 2, 2021
@release-clerk
Copy link

release-clerk bot commented Dec 2, 2021

Release Notes Persisted

Assertion failure happening in the showSaveDialogSync() code path has been fixed. (Fixes #31997)

@trop
Copy link
Contributor

trop bot commented Dec 2, 2021

I have automatically backported this PR to "14-x-y", please check out #32080

@trop
Copy link
Contributor

trop bot commented Dec 2, 2021

I have automatically backported this PR to "15-x-y", please check out #32081

@trop
Copy link
Contributor

trop bot commented Dec 2, 2021

I have automatically backported this PR to "16-x-y", please check out #32082

@trop
Copy link
Contributor

trop bot commented Dec 2, 2021

I have automatically backported this PR to "17-x-y", please check out #32083

@trop trop bot added merged/17-x-y and removed target/15-x-y labels Dec 2, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
In the synchronous code path, gtk_native_dialog_run() will call
gtk_native_dialog_show(). Previously this was causing an assertion to be
hit at run time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File open and save dialog cannot open on Linux KDE since Electron 14
3 participants