Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register wrong command for setAsDefaultProtocolClient #32220

Merged
merged 1 commit into from Jan 4, 2022
Merged

fix: register wrong command for setAsDefaultProtocolClient #32220

merged 1 commit into from Jan 4, 2022

Conversation

Shubham-Kumar-2000
Copy link
Contributor

@Shubham-Kumar-2000 Shubham-Kumar-2000 commented Dec 16, 2021 •
edited by codebytere

Description of Change

Closes #32141

Added quotes in command registry so that bat complier think it as a single argument.

Checklist

Release Notes

Notes: Bug fixed for registering protocol in windows which used to set invalid command if the execution path included space.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 16, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 23, 2021
@codebytere codebytere changed the title fix: #32141 register wrong command for setAsDefaultProtocolClient for… fix: register wrong command for setAsDefaultProtocolClient Jan 3, 2022
@codebytere codebytere added target/14-x-y semver/patch backwards-compatible bug fixes labels Jan 3, 2022
@zcbenz zcbenz merged commit cbdb2e6 into electron:main Jan 4, 2022
@welcome
Copy link

welcome bot commented Jan 4, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jan 4, 2022

Release Notes Persisted

Bug fixed for registering protocol in windows which used to set invalid command if the execution path included space.

This was referenced Jan 4, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jan 4, 2022

I have automatically backported this PR to "14-x-y", please check out #32328

@trop trop bot mentioned this pull request Jan 4, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Jan 4, 2022

I have automatically backported this PR to "17-x-y", please check out #32329

@trop
Copy link
Contributor

trop bot commented Jan 4, 2022

I have automatically backported this PR to "15-x-y", please check out #32330

@trop trop bot added the in-flight/17-x-y label Jan 4, 2022
@trop
Copy link
Contributor

trop bot commented Jan 4, 2022

I have automatically backported this PR to "16-x-y", please check out #32331

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@Shubham-Kumar-2000 @t57ser
fix: electron#32141 register wrong command for setAsDefaultProtocolCl…
f74198a 
…ient for windows (electron#32220)
@commit-lint commit-lint bot mentioned this pull request Mar 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Register wrong command for setAsDefaultProtocolClient
3 participants
@Shubham-Kumar-2000 @zcbenz @codebytere