New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use setAspectRatio for frameless window on mac #32287
fix: use setAspectRatio for frameless window on mac #32287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is just waiting for a report back from a lintbot that got lost.
@gerhardberger could you push a merge that updates from main
just to kick off the bots again?
Release Notes Persisted
|
I have automatically backported this PR to "15-x-y", please check out #32445 |
I have automatically backported this PR to "16-x-y", please check out #32446 |
I have automatically backported this PR to "17-x-y", please check out #32447 |
* fix(window): setAspectRatio for frameless windows * dummy * undo dummy Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Description of Change
On macOS, NSWindow.setContentAspectRatio was being used to set the aspect ratio. However this works incorrectly for frameless windows, causing a jump in window size, when starting the resize. But using NSWindow.setAspectRatio, it works correctly for frameless windows (but not for framed windows, so we still have to use setContentAspectRatio in that case.)
Before:
Screen.Recording.2021-12-26.at.16.18.56.mov
After:
Screen.Recording.2021-12-26.at.16.18.11.mov
Checklist
npm test
passesRelease Notes
Notes: Fixes aspect ratio resize for frameless windows on macOS.