New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose blowfish cipher family #32356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM though i think you need to fix an undefined symbol issue.
@nornagon some of the Node.js tests still need to be updated it looks like - they expect undefined but we're now returning the bf data:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Release Notes Persisted
|
I have automatically backported this PR to "17-x-y", please check out #32439 |
Description of Change
Adds support for bf-{cbc,cfb,ecb} to the nodejs crypto api.
These ciphers are obsolete, but some applications still depend on them, and
boringssl has the code, so we might as well expose them.
Closes #20238.
Checklist
npm test
passesRelease Notes
Notes: Support obsolete blowfish ciphers bf-{cbc,cfb,ecb} through the Node.js crypto API.