Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow x64 arch on Mac Rosetta #32380

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 7, 2022

Backport of #32266

See that PR for details.

Notes: Allowed specifying x64 arch on Mac Rosetta via npm_config_arch.

If the npm_config_arch environment variable is set on Mac, then use the
specified architecture rather than overriding it to x64.
@trop trop bot requested a review from a team as a code owner January 7, 2022 08:53
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 7, 2022
@trop trop bot mentioned this pull request Jan 7, 2022
2 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 7, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 7, 2022
@codebytere codebytere merged commit a18a460 into 15-x-y Jan 10, 2022
@codebytere codebytere deleted the trop/15-x-y-bp-fix-allow-x64-arch-on-mac-rosetta-1641545626196 branch January 10, 2022 09:49
@release-clerk
Copy link

release-clerk bot commented Jan 10, 2022

Release Notes Persisted

Allowed specifying x64 arch on Mac Rosetta via npm_config_arch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants