Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: desktop screen capture on macOS not releasing #32435

Merged
merged 1 commit into from Jan 13, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Fixes #32358.

Fixes an issue where calling screen capture on macOS does not properly release underlying OS capture mechanisms. As a result of this issue, calls made to capture screen finish within Electron, but if a user locks their screen they would see the following message until the app itself is quit:

Screen Shot 2022-01-12 at 3 28 12 PM

I bisected this to v16.0.0-nightly.20210903...v16.0.0-nightly.20210906 and then narrowed the culprit to 1dcb8a3. Within this the change that looked most suspicious was the removal of capturer_.reset() and upon restoring it I verified that this fixed the problem.

Tested with https://gist.github.com/7e85744c4a498a6fa210bae966bfc44f.

Checklist

Release Notes

Notes: Fixed an issue where calling screen capture on macOS does not properly release underlying OS capture mechanisms.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/16-x-y labels Jan 12, 2022
@codebytere codebytere requested a review from a team as a code owner January 12, 2022 14:37
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 12, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 13, 2022
@codebytere codebytere merged commit 7f4efb6 into main Jan 13, 2022
@codebytere codebytere deleted the fix-desktop-capturer-stoppage branch January 13, 2022 15:21
@release-clerk
Copy link

release-clerk bot commented Jan 13, 2022

Release Notes Persisted

Fixed an issue where calling screen capture on macOS does not properly release underlying OS capture mechanisms.

@trop
Copy link
Contributor

trop bot commented Jan 13, 2022

I have automatically backported this PR to "17-x-y", please check out #32464

@trop
Copy link
Contributor

trop bot commented Jan 13, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@seanmacisaac
Copy link

seanmacisaac commented Jan 15, 2022

Apologies if the the process is documented somewhere, but any idea when this will get put into 16-x-y and a point release made? Thanks! Also thanks for looking at it and getting it fixed.

@trop
Copy link
Contributor

trop bot commented Mar 16, 2022

@codebytere has manually backported this PR to "16-x-y", please check out #33314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: getSources not releasing OS capture in MacOS Big Sur
4 participants