fix: crash when saving edited PDF files #32512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
approved these changes
Jan 18, 2022
VerteDinde
approved these changes
Jan 18, 2022
jkleinsc
requested changes
Jan 18, 2022
codebytere
force-pushed
the
fix-pdf-download-crash
branch
from
4566ca3
to
558cb32
Compare
jkleinsc
approved these changes
Jan 18, 2022
nornagon
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Can you try upstreaming this? The chrome.fileSystem API is apparently deprecated, so upstream might be interested in help moving off it :)
|
Release Notes Persisted
|
This was referenced Jan 19, 2022
|
I have automatically backported this PR to "15-x-y", please check out #32537 |
|
I have automatically backported this PR to "16-x-y", please check out #32538 |
|
I have automatically backported this PR to "17-x-y", please check out #32539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32476.
This commit fixes a crash that persists any time a user attempts to download an edited PDF. This was happening because the logic flow for download of any edited PDF triggers a call to
chrome.fileSystem.chooseEntry, which we do not support and which cause unmapped page access crashes.This patch can be removed should we choose to support
chrome.fileSystemor support it enough to fix the crash.Checklist
npm testpassesRelease Notes
Notes: Fixed a crash that occurred when user attempted to download an edited PDF