New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: undefined backgroundColor #32517
Conversation
Release Notes Persisted
|
I was unable to backport this PR to "16-x-y" cleanly; |
I was unable to backport this PR to "17-x-y" cleanly; |
@codebytere has manually backported this PR to "17-x-y", please check out #32653 |
@codebytere has manually backported this PR to "16-x-y", please check out #32654 |
Description of Change
Closes #32007.
Fixes an issue where if
backgroundColor
was set toundefined
, vibrancy failed to work and thebackgroundColor
would show up as white. This was happening because we were converting the background color from an arbitraryv8::Value
, when we only accept strings. As a result,undefined
would returntrue
from the conversion instead of false as it should. Fix this by expecting the more specific type.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where if
backgroundColor
was set toundefined
, vibrancy failed to work and thebackgroundColor
would show up as white.