Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined backgroundColor #32653

Merged
merged 1 commit into from Jan 31, 2022
Merged

fix: undefined backgroundColor #32653

merged 1 commit into from Jan 31, 2022

Conversation

codebytere
Copy link
Member

Backport of #32517.

See that PR for details.

Notes: Fixed an issue where if backgroundColor was set to undefined, vibrancy failed to work and the backgroundColor would show up as white.

@codebytere codebytere requested a review from a team January 27, 2022 19:59
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 27, 2022
@trop trop bot mentioned this pull request Jan 27, 2022
Merged
3 tasks
@trop trop bot added 17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 27, 2022
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jan 27, 2022
@codebytere codebytere merged commit a226855 into 17-x-y Jan 31, 2022
@codebytere codebytere deleted the undefined-bg-17 branch January 31, 2022 13:40
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2022

Release Notes Persisted

Fixed an issue where if backgroundColor was set to undefined, vibrancy failed to work and the backgroundColor would show up as white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
17-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @zcbenz @VerteDinde @MarshallOfSound