New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some frameless windows showing a frame on Windows #32692
Conversation
a7694bb
to
b4c71a2
Compare
Release Notes Persisted
|
I have automatically backported this PR to "17-x-y", please check out #32707 |
I have automatically backported this PR to "15-x-y", please check out #32708 |
I have automatically backported this PR to "14-x-y", please check out #32709 |
I have automatically backported this PR to "16-x-y", please check out #32710 |
This reverts commit 7c70136.
…lectron#32692)" (electron#33599) This reverts commit 7c70136.
…lectron#32692)" (electron#33599) This reverts commit 7c70136.
Description of Change
Closes #30760.
Fixes an issue where frameless windows would show chrome during the loading process when they shouldn't. Cleans up the logic for
SetWindowLong
GWL_STYLE
application to ensure thatWS_CAPTION
is removed when the window is frameless and not just whenthickFrame
is false.Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where frameless windows on Windows would incorrectly show a small frame during the loading process.