New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make ElectronBrowser mojo interface frame associated. #32734
fix: Make ElectronBrowser mojo interface frame associated. #32734
Conversation
Release Notes Persisted
|
I have automatically backported this PR to "17-x-y", please check out #32815 |
@marekharanczyk do we need to backport this to 15-x-y and 16-x-y as well? |
I think it needs backporting to 18-x-y as that branch was created after PR, so it is on main and 17 but not 18. Regarding older branches, the problem is definitely there, just hidden for that specific case due to other code, but I am not going to make a call on that, those are stable branches after all and I had not compiled nor tested it extensively there to take that risk. |
/trop run backport-to 18-x-y |
The backport process for this PR has been manually initiated - sending your PR to |
I have automatically backported this PR to "18-x-y", please check out #32851 |
Description of Change
Switch electron implementation of mojo interface to use same message pipe as some if interfaces handling frame in chromium. This will assure proper sequencing of events on browser side wrt electron ipc and frame handling. Otherwise race condition could be seen when objects operating on same models in browser process as standard web api is using, for example:
will be racy without the change and ipc event could be handled before window is created (albeit rarely as it is timing dependent).
Checklist
npm test
passesRelease Notes
Notes: Fixed possible race conditions between frame state and electron ipc.