Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failure to print on macOS #32767

Merged
merged 1 commit into from Feb 8, 2022
Merged

fix: failure to print on macOS #32767

merged 1 commit into from Feb 8, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #32750.

Fixes an issue where the page would not properly render to print on macOS with the following error:

Printer: print_job_worker.cc:560 Failure to render printed document - error kFailed

Can be removed when #32419 is merged but given that it's paused right now i'd like to fix this issue as soon as possible.

Tested with https://gist.github.com/1ab968669f64a7707306e876ab2ff5bc.

Checklist

Release Notes

Notes: Fixed an issue where pages would not properly print on macOS due to a rendering failure.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/17-x-y labels Feb 7, 2022
@codebytere codebytere requested a review from a team as a code owner February 7, 2022 09:46
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 7, 2022
@codebytere codebytere mentioned this pull request Feb 7, 2022
Closed
3 tasks
@deepak1556
Copy link
Member

#32750 is addressed by #32632 right ? This change only affects macOS and should be unrelated to report #32750 IIUC.

deepak1556
deepak1556 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the backport

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2022
@codebytere codebytere merged commit 58af7d2 into main Feb 8, 2022
@codebytere codebytere deleted the fix-print-not-rendering branch February 8, 2022 15:15
@release-clerk
Copy link

release-clerk bot commented Feb 8, 2022

Release Notes Persisted

Fixed an issue where pages would not properly print on macOS due to a rendering failure.

@trop trop bot mentioned this pull request Feb 8, 2022
Closed
@trop
Copy link
Contributor

trop bot commented Feb 8, 2022

I have automatically backported this PR to "17-x-y", please check out #32812

@codebytere
Copy link
Member Author

/trop run backport-to 18-x-y

@trop
Copy link
Contributor

trop bot commented Feb 8, 2022

The backport process for this PR has been manually initiated - sending your PR to 18-x-y!

@trop trop bot mentioned this pull request Feb 8, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Feb 8, 2022

I have automatically backported this PR to "18-x-y", please check out #32813

@trop trop bot added the in-flight/18-x-y label Feb 8, 2022
@commit-lint commit-lint bot mentioned this pull request Apr 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: webContents.print() crashes with a non-null callback
2 participants
@codebytere @deepak1556