Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pointer lock escape handling #32828

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 9, 2022

Backport of #32369

See that PR for details.

Notes: Fixed an issue where Pointer Lock behavior could not be properly exited.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2022
@trop trop bot requested a review from codebytere February 9, 2022 09:41
@trop trop bot mentioned this pull request Feb 9, 2022
3 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 9, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2022
zcbenz
zcbenz previously requested changes Feb 14, 2022
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark as request changes since there is test failing.

@miniak miniak force-pushed the trop/18-x-y-bp-fix-pointer-lock-escape-handling-1644399695101 branch from d9ea5b7 to 4b5f1ba Compare March 30, 2022 01:56
@codebytere codebytere dismissed zcbenz’s stale review March 30, 2022 07:41

test no longe failing

@codebytere codebytere merged commit befe53e into 18-x-y Mar 30, 2022
@codebytere codebytere deleted the trop/18-x-y-bp-fix-pointer-lock-escape-handling-1644399695101 branch March 30, 2022 07:41
@release-clerk
Copy link

release-clerk bot commented Mar 30, 2022

Release Notes Persisted

Fixed an issue where Pointer Lock behavior could not be properly exited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants