Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport EPROTOTYPE fixes from libuv #32856

Merged
merged 1 commit into from Feb 17, 2022

Conversation

indutny
Copy link
Contributor

@indutny indutny commented Feb 10, 2022

Description of Change

This commit backports three commits from libuv's 1.x branch to fix
issues with CPU going to 100% on macOS when EPROTOTYPE is returned.

For electron-specific discussion: libuv/libuv#482 (comment)

See: libuv/libuv@abb109f
See: libuv/libuv@3a7b955
See: libuv/libuv@de24da8

cc @nornagon @codebytere

Checklist

Release Notes

Notes: chore: backport EPROTOTYPE fixes from libuv

This commit backports three commits from libuv's 1.x branch to fix
issues with CPU going to 100% on macOS when EPROTOTYPE is returned.

See: libuv/libuv@abb109f
See: libuv/libuv@3a7b955
See: libuv/libuv@de24da8
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Feb 10, 2022
@indutny-signal
Copy link
Contributor

@codebytere thanks for the review. Just to make sure it doesn't slip by, this will increase minimum macOS version to 10.15. Is it alright? Would this affect versions that would receive backport?

Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our minimum supported version is aligned with chromium, basically the values set by https://source.chromium.org/chromium/chromium/src/+/main:build/config/mac/mac_sdk.gni;l=15-30

I think as long as the libuv backports work, it should be fine. And given the commit details libuv/libuv@3a7b955 I think this one should be good for backport.

@indutny-signal
Copy link
Contributor

Awesome. We'd certainly appreciate a backport to 16-x-y. Thanks!

@zcbenz zcbenz merged commit fe43296 into electron:main Feb 17, 2022
@release-clerk
Copy link

release-clerk bot commented Feb 17, 2022

Release Notes Persisted

chore: backport EPROTOTYPE fixes from libuv

@trop
Copy link
Contributor

trop bot commented Feb 17, 2022

I have automatically backported this PR to "16-x-y", please check out #32942

@trop
Copy link
Contributor

trop bot commented Feb 17, 2022

I have automatically backported this PR to "17-x-y", please check out #32943

@trop
Copy link
Contributor

trop bot commented Feb 17, 2022

I have automatically backported this PR to "18-x-y", please check out #32944

bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
This commit backports three commits from libuv's 1.x branch to fix
issues with CPU going to 100% on macOS when EPROTOTYPE is returned.

See: libuv/libuv@abb109f
See: libuv/libuv@3a7b955
See: libuv/libuv@de24da8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants