New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport EPROTOTYPE fixes from libuv #32856
Conversation
This commit backports three commits from libuv's 1.x branch to fix issues with CPU going to 100% on macOS when EPROTOTYPE is returned. See: libuv/libuv@abb109f See: libuv/libuv@3a7b955 See: libuv/libuv@de24da8
@codebytere thanks for the review. Just to make sure it doesn't slip by, this will increase minimum macOS version to 10.15. Is it alright? Would this affect versions that would receive backport? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our minimum supported version is aligned with chromium, basically the values set by https://source.chromium.org/chromium/chromium/src/+/main:build/config/mac/mac_sdk.gni;l=15-30
I think as long as the libuv backports work, it should be fine. And given the commit details libuv/libuv@3a7b955 I think this one should be good for backport.
Awesome. We'd certainly appreciate a backport to 16-x-y. Thanks! |
Release Notes Persisted
|
I have automatically backported this PR to "16-x-y", please check out #32942 |
I have automatically backported this PR to "17-x-y", please check out #32943 |
I have automatically backported this PR to "18-x-y", please check out #32944 |
This commit backports three commits from libuv's 1.x branch to fix issues with CPU going to 100% on macOS when EPROTOTYPE is returned. See: libuv/libuv@abb109f See: libuv/libuv@3a7b955 See: libuv/libuv@de24da8
Description of Change
This commit backports three commits from libuv's 1.x branch to fix
issues with CPU going to 100% on macOS when EPROTOTYPE is returned.
For electron-specific discussion: libuv/libuv#482 (comment)
See: libuv/libuv@abb109f
See: libuv/libuv@3a7b955
See: libuv/libuv@de24da8
cc @nornagon @codebytere
Checklist
npm test
passesRelease Notes
Notes: chore: backport EPROTOTYPE fixes from libuv