Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn that preloads will be sandboxed by default in v20 #32868

Merged
merged 3 commits into from Mar 8, 2022

Conversation

nornagon
Copy link
Member

Description of Change

Per #28466 (comment),
though a little delayed.

Checklist

Release Notes

Notes: Added warning that preload scripts will be sandboxed by default beginning in Electron 20.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2022
@nornagon nornagon mentioned this pull request Feb 11, 2022
5 tasks
@nornagon nornagon added the semver/minor backwards-compatible functionality label Feb 15, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2022
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@nornagon
Copy link
Member Author

nornagon commented Mar 8, 2022

Build failures are unrelated to this PR and are fixed on main; merging.

@nornagon nornagon merged commit 27527fe into main Mar 8, 2022
@nornagon nornagon deleted the warn-sandbox-default-changing branch March 8, 2022 23:39
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2022

Release Notes Persisted

Added warning that preload scripts will be sandboxed by default beginning in Electron 20.

@trop
Copy link
Contributor

trop bot commented Mar 8, 2022

I have automatically backported this PR to "18-x-y", please check out #33203

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/approved ✅ semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants