New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken OSR transparent option #32885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
requested review from
jkleinsc,
zcbenz,
samuelmaddock and
MarshallOfSound
February 14, 2022 10:55
samuelmaddock
approved these changes
Feb 14, 2022
zcbenz
approved these changes
Feb 16, 2022
codebytere
force-pushed
the
fix-osr-transparency
branch
2 times, most recently
from
February 21, 2022 11:06
43eb737
to
ffc4a67
Compare
zcbenz
force-pushed
the
fix-osr-transparency
branch
from
February 23, 2022 07:50
5054b38
to
72135fd
Compare
Release Notes Persisted
|
This was referenced Feb 23, 2022
I have automatically backported this PR to "16-x-y", please check out #33051 |
I have automatically backported this PR to "17-x-y", please check out #33052 |
I have automatically backported this PR to "18-x-y", please check out #33053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #32846.
Traced back to #30778 - we no longer have a transparent option in
webPreferences
, and soelectron/shell/browser/api/electron_api_web_contents.cc
Line 771 in 28ada6e
webPreferences
by propagating it towebPreferences
in theBrowserWindow
ctor:electron/shell/browser/api/electron_api_browser_window.cc
Lines 56 to 57 in 28ada6e
backgroundColor
being set to the hex equivalent ofSK_ColorTRANSPARENT
and proceed with that value.Tested with https://gist.github.com/29850810e9c5892587729d3d64a25761.
Checklist
npm test
passesRelease Notes
Notes: Fixed broken transparency option in offscreen window rendering.