feat: add WCO height option #32939
Merged
feat: add WCO height option #32939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add WCO height option * add docs and mac functionality * add macOS functionality and height lowerbound * Update docs/api/browser-window.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> * update macOS functionality * add chromium related notes * add test and fix pixel under button bug and fix typo * revert changes to docs/api/frameless-window.md * modify `useCustomHeight` calls * update `useCustomHeight` and `getCurrentMargin` * modify margin calculation * fix minimum custom height on macOS * Update window_buttons_proxy.mm * fix specified traffic light positions Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
trop
bot
added
17-x-y
backport
jkleinsc
approved these changes
Feb 22, 2022
|
Release Notes Persisted
|
|
/trop run backport-to 16-x-y,15-x-y,14-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "16-x-y" cleanly; |
|
I was unable to backport this PR to "15-x-y" cleanly; |
|
I was unable to backport this PR to "14-x-y" cleanly; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #31222
See that PR for details
Notes: Added
heightoption for Windows Control Overlay