Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: command string for windows protocol handler #32953

Merged
merged 1 commit into from Feb 21, 2022

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Feb 17, 2022

Description of Change

Enclose all arguments in quotation marks so that application can respect the individual arguments.

Before:

"C:\example\node_modules\electron\dist\electron.exe" "c:\example --arg" "%1"

After:

"C:\example\node_modules\electron\dist\electron.exe" "c:\example" "--arg" "%1"

Refs microsoft/vscode#142685
Fixes #32463

Checklist

Release Notes

Notes: fix command string registered via setAsDefaultProtocolClient on windows

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2022
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/16-x-y labels Feb 17, 2022
@deepak1556 deepak1556 requested a review from a team as a code owner February 17, 2022 11:24
@deepak1556 deepak1556 removed the request for review from a team February 17, 2022 13:43
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2022
@zcbenz zcbenz merged commit bdad633 into main Feb 21, 2022
@zcbenz zcbenz deleted the robo/fix_protocol_client_win branch February 21, 2022 07:43
@release-clerk
Copy link

release-clerk bot commented Feb 21, 2022

Release Notes Persisted

fix command string registered via setAsDefaultProtocolClient on windows

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "14-x-y", please check out #33009

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "16-x-y", please check out #33010

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "15-x-y", please check out #33011

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "17-x-y", please check out #33012

@trop
Copy link
Contributor

trop bot commented Feb 21, 2022

I have automatically backported this PR to "18-x-y", please check out #33013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: setAsDefaultProtocolClient sets wrong command
4 participants