Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nativeTheme.inForcedColorsMode #32956

Merged
merged 1 commit into from Mar 21, 2022
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 17, 2022

Description of Change

https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/

Checklist

Release Notes

Notes: Added nativeTheme.inForcedColorsMode API to allow detecting forced color mode.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 17, 2022
@miniak miniak self-assigned this Feb 17, 2022
@miniak miniak added semver/minor backwards-compatible functionality target/15-x-y labels Feb 17, 2022
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere
Copy link
Member

Unrelated failure - known flake.

@codebytere codebytere merged commit 755feb4 into main Mar 21, 2022
@codebytere codebytere deleted the miniak/forced-colors-mode branch March 21, 2022 09:30
@release-clerk
Copy link

release-clerk bot commented Mar 21, 2022

Release Notes Persisted

Added nativeTheme.inForcedColorsMode API to allow detecting forced color mode.

@trop
Copy link
Contributor

trop bot commented Mar 21, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 21, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/17-x-y label Mar 21, 2022
@trop
Copy link
Contributor

trop bot commented Mar 21, 2022

@miniak has manually backported this PR to "17-x-y", please check out #33358

@trop
Copy link
Contributor

trop bot commented Mar 21, 2022

@miniak has manually backported this PR to "16-x-y", please check out #33359

@trop
Copy link
Contributor

trop bot commented Mar 21, 2022

@miniak has manually backported this PR to "15-x-y", please check out #33360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/approved ✅ semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants