fix: fire show event when BrowserWindow shown via maximize() #32979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
fix-32976
branch
from
90aba1f
to
659d2df
Compare
|
Looks like the Windows builds unfortunately failed because they hit a 120 minute build time limit. |
codebytere
approved these changes
Feb 21, 2022
jkleinsc
approved these changes
Mar 9, 2022
|
Release Notes Persisted
|
|
I have automatically backported this PR to "16-x-y", please check out #33212 |
This was referenced Mar 9, 2022
|
I have automatically backported this PR to "17-x-y", please check out #33213 |
|
I have automatically backported this PR to "18-x-y", please check out #33214 |
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #32976.
This doesn't fix macOS (see #32947), only Windows and Linux, but the test will ensure that it works on macOS as well once that issue is closed.
This is somewhat of a half measure to address this particular case, instead of a holistic sweep to ensure 'show' is fired any time a BrowserWindow transitions from unshown to shown. I think that would be a good thing to do, but I don't have the bandwidth to do that at the moment (this is like, the 3rd issue in a chain of blocking issues), so this will serve as an incremental step in that direction which also adds test coverage.
Checklist
npm testpassesRelease Notes
Notes: Fire 'show' event when a BrowserWindow is shown via maximize()