Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: savePage throw on relative paths #33017

Merged
merged 1 commit into from Feb 22, 2022
Merged

fix: savePage throw on relative paths #33017

merged 1 commit into from Feb 22, 2022

Conversation

codebytere
Copy link
Member

Backport of #32728.
Backport of #32727.

See that PR for details.

Notes: Fixed an issue where webContents.savePage failed when passing a relative path instead of an absolute one.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2022
@trop trop bot mentioned this pull request Feb 21, 2022
4 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 21, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2022
@trop trop bot mentioned this pull request Feb 21, 2022
4 tasks
@trop trop bot added the semver/none label Feb 21, 2022
@zcbenz zcbenz merged commit f92f979 into 16-x-y Feb 22, 2022
@zcbenz zcbenz deleted the savepage-16 branch February 22, 2022 07:30
@release-clerk
Copy link

release-clerk bot commented Feb 22, 2022

Release Notes Persisted

Fixed an issue where webContents.savePage failed when passing a relative path instead of an absolute one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants