New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect tray garbage collection #33040
Conversation
Failures:
Are known and unrelated. |
Release Notes Persisted
|
I have automatically backported this PR to "18-x-y", please check out #33074 |
I have automatically backported this PR to "16-x-y", please check out #33075 |
I have automatically backported this PR to "17-x-y", please check out #33076 |
I have automatically backported this PR to "15-x-y", please check out #33077 |
Description of Change
Closes #31564.
Fixes an issue where the Tray could get garbage collected incorrectly under some circumstances.
I bisected this to v10.0.0-nightly.20200310...v10.0.0-nightly.20200311 - which was the diff that removed the catch-all
HandleScope
. For some trays, this wasn't an issue - if they had a menu, for example, those are prevented from being GC'd which also prevented Tray GC. We fix this by pinning the Tray, in similar fashion to what's done with, for example,BrowserView
.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where the Tray could get garbage collected incorrectly under some circumstances.